Pin GitHub Actions to commit SHAs - #486
Merged
Merged
Conversation
joe4dev
added
semver: patch
docs: skip
joe4dev
force-pushed
the
devx-978-pin-github-actions-for-lstk
branch
2 times, most recently
from
September 8, 2026 10:41
7662ea8 to
5d6a103
Compare
joe4dev
marked this pull request as ready for review
September 8, 2026 11:40
joe4dev
enabled auto-merge (rebase)
September 8, 2026 11:59
Co-Authored-By: Claude <noreply@anthropic.com>
joe4dev
force-pushed
the
devx-978-pin-github-actions-for-lstk
branch
from
September 8, 2026 11:59
5d6a103 to
905988c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Mutable tags (
@v7,@v1) let an upstream retag change what runs in CI — including the workflows holdingPRO_ACCESS_TOKEN,NPM_AUTH_TOKEN, and the release path.enforce-labels.ymlandsync-labels.ymlwere already pinned (#307); this finishes the rest.Solution
All 45 external
uses:refs across 6 workflows pinned to full commit SHAs with a# vX.Y.Zcomment.Each SHA is the commit the tag pointed at when this branch was cut (
gh api repos/<owner>/<repo>/commits/<tag>), so nothing upstream is adopted here — no behavior change.aws-actions/setup-sampublishes only major tags, hence its bare# v3. Dependabot bumps SHA and comment together. The 3 local./.github/...refs stay unpinned.Also corrects one misleading pre-existing comment:
sync-labels.yml's pin read# main, which claims to track a branch that has since moved 8 commits ahead.localstack/metapublishes no tags, so it now reads# main @ 2026-04-22— the branch and the date it was pinned from. The commit is unchanged, and the reusable workflow we consume hasn't changed since.Verification
git diff -U0shows onlyuses:lines changed; no external ref lacks a 40-char SHA; all workflows still parse. CI on this PR is the real check.Docs
Nothing to document.
CI-only change — no user-facing behavior, flags, config, or output.
Review
Self-merge candidate. Every line is a tag-to-SHA swap a reviewer can verify with
gh api repos/<owner>/<repo>/commits/<tag>.Closes DEVX-978
Co-Authored-By: Claude noreply@anthropic.com